docs: Safety docs - #6307
Merged
Merged
Conversation
Person-93
marked this pull request as ready for review
August 7, 2026 08:07
davidhewitt
reviewed
Aug 12, 2026
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks, this is much appreciated, the refactoring is great and has prompted a couple further ideas.
Person-93
force-pushed
the
safety-docs
branch
2 times, most recently
from
August 13, 2026 01:51
ad0ad98 to
d9d7651
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
Just copied existing safety comment to more places
davidhewitt
approved these changes
Aug 16, 2026
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks, this is a great improvement in safety & quality 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add safety docs to a few files. I've refactored a bit of
internal/state.rsinto a submodule to contain some of its unsafe assumptions.While I was in
internal/state.rs, I also removed aOnceLockthat was unnecessarily wrapping aMutex.